/moose/svnweb/index.cgi/moose/log/ 2008-11-19T16:12:04 SVN::Web daily 1 1901-01-01T00:00+00:00 /moose/svnweb/index.cgi/moose/revision?rev=6620 Implemented 'render' as a subroutine rather than 'handles' so it can be overridden
in the consuming view

isillitoe 2008-11-19T16:12:04 /moose/svnweb/index.cgi/moose/revision?rev=6619 Tagging version '0.70_01' using shipit. autarch 2008-11-19T14:50:17 /moose/svnweb/index.cgi/moose/revision?rev=6618 Doh, I'm retarded.

I already release 0.70, and then went and released 0.69_01.

Re-releasing with proper changes as 0.70_01 to get some testing autarch 2008-11-19T14:49:43 /moose/svnweb/index.cgi/moose/revision?rev=6617 Added/corrected tests

Added/corrected POD

MX::T::View
- build_source is now set_source (and is only setter for source)
- direct template source strings must be given as SCALAR REF
- interface now looks like:

render
set_source
get_source
engine
engine_class
engine_config
build_src_path
module
template_src_base
template_src_ext


isillitoe 2008-11-18T22:41:33 /moose/svnweb/index.cgi/moose/revision?rev=6616 Tagging version '0.69_01' using shipit. autarch 2008-11-18T16:04:49 /moose/svnweb/index.cgi/moose/revision?rev=6615 update Changes and make version 0.69_01 autarch 2008-11-18T15:58:04 /moose/svnweb/index.cgi/moose/revision?rev=6614 r75673@onn: sartak | 2008-11-17 17:43:52 -0500
Remove the make_immutable keyword, it's been deprecated and can break metaclasses
sartak 2008-11-17T22:44:32 /moose/svnweb/index.cgi/moose/revision?rev=6613
Changed the default method stub from _templated_source to _templated

Added/changed documentation and altered tests to reflect those changes.


isillitoe 2008-11-17T21:42:54 /moose/svnweb/index.cgi/moose/revision?rev=6612 SUMMARY

- changes to attribute names/defaults for better consistency across the public interface

templated_*

- render now provides new functionality, e.g.

Farm::Cow->new->render;
# tries:
# Farm::Cow::_templated_source()
# /path/to/Farm/Cow.tt

Farm::Cow->new->render( source => 'xml' );
# tries:
# Farm::Cow::_templated_source_xml()
# /path/to/Farm/Cow.xml.tt

Farm::Cow->new->render( source => 'Cow.tt' );
Farm::Cow->new->render( source => 'Cow goes [% self.moo %]' );

* seems ok, and written docs to explain steps used to figure out DWYM nature,
but maybe too flexible to try and 'coerce' all of these different usages
from string?

DETAILS

Index: lib/MooseX/Templated/Role.pm
===================================================================
- Changed public methods for consistency in 'templated'/'templated_view' namespace

template => templated_view
template_engine => <removed> (public don't need access to underlying engine)
template_src => <removed>
template_config => templated_view_config
=> templated_view_class (shorthand to specify own template view)

- Added a whole bunch (too much?) of docs to cover usage of render()

Index: lib/MooseX/Templated/View.pm
===================================================================
- changed attributes

- allows template source to be specified from internal methods of
consuming module (Farm::Cow::_templated_source())

- allows shortcuts for template source 'types'

Farm::Cow->new->render( source => 'xml' );
# tries:
# Farm::Cow::_templated_source_xml()
# /path/to/Farm/Cow.xml.tt

- build_source( base => '/path', ext => '.tt' )
- returns the source as string

- render( source => '', stash => '' )
- allows source to be set in the render
- placeholder for stash - TODO: implement and add tests
- requires 'process' in underlying engine

- updated docs


Index: t/lib/Farm/Cow.pm
===================================================================
- has 'hobbies'
- sub _templated_source_html

Index: t/01.api.t
===================================================================
- now just tests vanilla (synopsis) usage

Index: t/02.render.t
===================================================================
- tests the various ways of calling $self->render()

Index: t/lib/Farm/Cow.xml.tt
===================================================================
- added for t/02.render.t

Index: lib/MooseX/Templated/View/TT.pm
===================================================================
- brought inline with changes to lib/MooseX/Templated/View.pm

Index: Makefile.PL
===================================================================
- Corrected from MX::Templated.pm

Index: Build.PL
===================================================================
- Corrected from MX::Templated.pm
isillitoe 2008-11-17T18:22:19 /moose/svnweb/index.cgi/moose/revision?rev=6611 File was deleted - funcionality now split between MX::T::Role (front-end) and MX::T::View (back-end)
isillitoe 2008-11-17T11:52:27 /moose/svnweb/index.cgi/moose/revision?rev=6610 Default TT suffix was changed to '.tt'
isillitoe 2008-11-17T11:51:11 /moose/svnweb/index.cgi/moose/revision?rev=6609 more debugging, I hope this wont need another moose patch... jnapiorkowski 2008-11-17T03:27:51 /moose/svnweb/index.cgi/moose/revision?rev=6608 closer to the sketch actually working jnapiorkowski 2008-11-16T22:46:18 /moose/svnweb/index.cgi/moose/revision?rev=6607 Add a comment as per the traits case t0m 2008-11-16T17:56:58 /moose/svnweb/index.cgi/moose/revision?rev=6606 Fix another reentrancy issue in Moose::Exporter by additional localising of + test case t0m 2008-11-16T17:17:45 /moose/svnweb/index.cgi/moose/revision?rev=6605 Fix 1 char POD bug t0m 2008-11-16T17:14:56 /moose/svnweb/index.cgi/moose/revision?rev=6604 Don't declare return values for PPCODE.

This silences some more compiler warnings. rafl 2008-11-15T15:00:44 /moose/svnweb/index.cgi/moose/revision?rev=6603 Silence some compiler warnings. rafl 2008-11-15T15:00:35 /moose/svnweb/index.cgi/moose/revision?rev=6602 Don't try to get a CV from globs that are references, but not SvROK.

This might happen on newer perls where SVt_RV has been merged into SVt_IV.
Fixes RT#39149. rafl 2008-11-15T09:03:22 /moose/svnweb/index.cgi/moose/revision?rev=6601 Refactored project to allow different rendering engines after discussion with Chris Prather

Project now looks like:

MooseX::Templated::Role - public interface

template => {
does => MooseX::Templated::View,
handles => {
render => render,
}
}

MooseX::Templated::View - backend interface for template engines

requires 'render'

MooseX::Templated::View::TT - TT engine (default)

with 'MooseX::Templated::View'

NB: the coercion of MX::T::View::template_src isn't working (t/01.api.t fails) - haven't got time to fix

t/lib/Farm/Cow.pm
- now consumes 'MooseX::Templated::Role'

t/lib/Farm/Cow.t
- moved to t/lib/Farm/Cow.tt

t/01.api.t
- added some tests (some of which currently fail)

--This line, and those below, will be ignored--

M t/lib/Farm/Cow.pm
D t/lib/Farm/Cow.t
A t/lib/Farm/Cow.tt
M t/01.api.t
A lib/MooseX/Templated
A lib/MooseX/Templated/View.pm
A lib/MooseX/Templated/View
A lib/MooseX/Templated/View/TT.pm
A lib/MooseX/Templated/Role.pm
D lib/MooseX/Templated.pm perigrin 2008-11-15T05:48:06